Code and test improvement by analyzing the test coverage #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these tests have a lot of duplicates and private method coverage
combine logical blocks that have the same realization
return "has invalid rule" if any invalid rule is passed
return MsgInvalidValue if any invalid value is passed
return MsgInvalidValue if any invalid value is passed
return MsgInvalidValue if any invalid value is passed
return MsgInvalidValue if any invalid value is passed
use reflectValue.String() to avoid errors if any invalid value passed
use reflectValue.String() to avoid errors if any invalid value passed
values should not be checked inside the compare function, they should be checked inside each filter and modifier functions
the prototype filters should be checked inside the compare function before each filter and modifier function execution, thus, only values should be checked inside filters and modifiers
optional fields should be passed without validation if they are empty
these tests are intended to improve the indicators of the test coverage, which has a minor role at the time of writing, given the predicted state of the behavior of the main code, since this file tests behavior that should never be executed but is only an insurance against a change in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.21.0 – 2024-01-18
New Features
Refactors
Tests
Build System
Continuous Integration
Docs