Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_loader): add selected map loader #3

Conversation

Shin-kyoto
Copy link
Collaborator

@Shin-kyoto Shin-kyoto commented Apr 7, 2023

Description

These PRs must be merged before these PRs.

I would like to add selected map loader and metadata publisher to pointcloud_map_loader.

See https://github.com/orgs/autowarefoundation/discussions/2812#discussioncomment-5540316 for detail.

Related links

Tests performed

I tested with a data from Autoware tutorial. The map is divided into 20m grids (sample-map-rosbag_split.zip).

I have confirmed that the Autoware performs the same as the current Autoware when enable_selected_load is set false.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
…f metadata

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Copy link
Owner

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…s update

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
… metadata publisher

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 10, 2023
@Shin-kyoto Shin-kyoto marked this pull request as ready for review April 10, 2023 05:10
@yukkysaito yukkysaito merged commit 22a33bb into yukkysaito:feature/id_map_loader Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation launch map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants