Use element.isContentEditable. Preserve contenteditable undo stack.

[mikol]

Use element.isContentEditable.

element.contentEditable returns the string value of the contenteditable attribute, which is not a reliable indicator of the element’s editability. For example, the attribute values inherit and plaintext-only can indicate that an element is editable. This change uses the boolean element.isContentEditable property in place of element.contentEditable, which returns true when an element is editable and false when it is not, regardless of the contenteditable attribute value.

Preserve contenteditable undo stack.

Programatic DOM manipulations of contenteditable elements other than those made with document.execCommand() break the browser’s undo stack. For example, users are not able to undo past the last jquery-textcomplete interaction because it is currently manipulating the DOM through range.deleteContents() and range.insertNode(). These changes replace range manipulations with document.execCommand() operations thus preserving the browser’s undo stack, including all jquery-textcomplete interactions.

[yuku]

Hi @mikol, thanks for sending the patch.
It looks good to me!

[mikol]

Cool. Thanks!

/ Mikol

On Wed, Aug 6, 2014 at 1:46 AM, Yuku TAKAHASHI notifications@github.com
wrote:

Hi @mikol https://github.com/mikol, thanks for sending the patch.
It looks good to me!

—
Reply to this email directly or view it on GitHub
https://github.com/yuku-t/jquery-textcomplete/pull/98#issuecomment-51308442
.

[bettysteger]

hey @mikol @yuku-t ,

one question, this code is not in the latest version is it?

I would like to preserve the contenteditable undo stack :/

[mikol]

Hi, @lpsBetty –

Please excuse my slow reply. I am on vacation right now.

The precise code I submitted does not appear to be there any longer. But that doesn’t mean the correct support for editable content is gone. For example, the current code does use the .isContentEditable boolean, which was one of the things my PR introduced.

But I am not really a project maintainer and I only contributed this one time. I have not followed the project closely since then so I must defer all detailed Q&A about this subject to others. Perhaps I could lend a hand with a new PR if you create an issue outlining the problems you are having and how to reproduce them.

Best.

[bettysteger]

hey @mikol, thanks for your reply.

I just wanted the undo back, so that it's possible to remove a added textcomplete item with CTRL+Z ;)