Added the ability to insert HTML into a "contenteditable" field #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes allow the "replace" function of the strategy to return HTML for both the pre and the post parts. The HTML is then inserted correctly and the cursor positioned in between them. With this, it is for example possible to directly insert smiley <img> etc.. This should also resolve issue #105.
|
Nice enhancement 👍 |
yuku
added a commit
that referenced
this pull request
Mar 9, 2016
Added the ability to insert HTML into a "contenteditable" field
|
Hi @maxdev1, thanks for the patch and sorry for my late reply! |
|
This change breaks the case that the "replace" function returned an empty string, which is something that I was doing to insert HTML in place of the string that was entered. ( |
yuku
added
the
DEPRECATED jquery-textcomplete
|
This fix seemed to have been lost |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the "replace" function of the strategy to return![]()
etc.. This should
HTML for both the pre and the post parts. The HTML is then inserted
correctly and the cursor positioned in between them. With this, it is
for example possible to directly insert smiley
also resolve issue #105.
You could extend the Demo with the help of this feature, might convince
even more people to use it! :-)