fix: compile in all languages without error #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunanwg
approved these changes
Jul 13, 2024
|
Hi @landry-r thanks for raising this PR! I am passing this PR as the last major changes to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Firstly, I have fixed the template to ensure it compiles in all languages without any modifications. There were some files missing in the language module folder which I have now added. I also had to make minor changes in the text to ensure the output fits on one page.
Secondly, I believe it doesn't make sense to have an empty language field, as both "" and "en" default to English. I propose we set English ("en") as the default language, and then the user can explicitly choose a different language if needed.