Skip to content

Commit

Permalink
Revert "Change to content hash for RN canary VERSION strings (faceboo…
Browse files Browse the repository at this point in the history
…k#28582)"

This reverts commit cb076b5.
  • Loading branch information
yungsters committed May 30, 2024
1 parent d01ebc8 commit 3b15879
Showing 1 changed file with 19 additions and 13 deletions.
32 changes: 19 additions & 13 deletions scripts/rollup/build-all-release-channels.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,17 +173,25 @@ function processStable(buildDir) {
);
}

[
buildDir + '/react-native/implementations/',
buildDir + '/facebook-react-native/',
].forEach(reactNativeBuildDir => {
if (fs.existsSync(reactNativeBuildDir)) {
updatePlaceholderReactVersionInCompiledArtifacts(
reactNativeBuildDir,
ReactVersion + '-' + canaryChannelLabel + '-%FILEHASH%'
);
const reactNativeBuildDir = buildDir + '/react-native/implementations/';
if (fs.existsSync(reactNativeBuildDir)) {
const hash = crypto.createHash('sha1');
for (const fileName of fs.readdirSync(reactNativeBuildDir).sort()) {
const filePath = reactNativeBuildDir + fileName;
const stats = fs.statSync(filePath);
if (!stats.isDirectory()) {
hash.update(fs.readFileSync(filePath));
}
}
});
updatePlaceholderReactVersionInCompiledArtifacts(
reactNativeBuildDir,
ReactVersion +
'-' +
canaryChannelLabel +
'-' +
hash.digest('hex').slice(0, 8)
);
}

// Update remaining placeholders with canary channel version
updatePlaceholderReactVersionInCompiledArtifacts(
Expand Down Expand Up @@ -354,11 +362,9 @@ function updatePlaceholderReactVersionInCompiledArtifacts(

for (const artifactFilename of artifactFilenames) {
const originalText = fs.readFileSync(artifactFilename, 'utf8');
const fileHash = crypto.createHash('sha1');
fileHash.update(originalText);
const replacedText = originalText.replaceAll(
PLACEHOLDER_REACT_VERSION,
newVersion.replace(/%FILEHASH%/g, fileHash.digest('hex').slice(0, 8))
newVersion
);
fs.writeFileSync(artifactFilename, replacedText);
}
Expand Down

0 comments on commit 3b15879

Please sign in to comment.