fix(influxdb): support set timeout #19593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zexi
reviewed
Mar 1, 2024
pkg/util/influxdb/influxdb.go
Outdated
| @@ -299,3 +300,7 @@ func (db *SInfluxdb) SetRetentionPolicy(rp SRetentionPolicy) error { | |||
| return db.CreateRetentionPolicy(rp) | |||
| } | |||
| } | |||
|
|
|||
| func (db *SInfluxdb) SetTimeout(timeout time.Duration) { | |||
| db.client = httputils.GetTimeoutClient(timeout) | |||
There was a problem hiding this comment.
直接设置 db.client.Timeout = timeout 可以吗？这样不用构造新的对象
gouqi11
force-pushed
the
supportSetTimeoutForInflux
branch
from
d8af957 to
9c47d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Does this PR need to be backport to the previous release branch?:
If yes, write the release branches name in the below format and submit the related cherry-pick PR: