Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/On different height of the ContentGroup elements #4

Closed
jan-capiak opened this issue Sep 6, 2018 · 5 comments
Closed

Bug/On different height of the ContentGroup elements #4

jan-capiak opened this issue Sep 6, 2018 · 5 comments

Comments

@jan-capiak
Copy link

Hello,
I really like this Navbar, but i found a bug, that makes me crazy :)

This Bug can be found as well on your example website here: https://build-licattzisr.now.sh/

When you have like in the example above, different height of ContentGroup, you can see this bug.
spa-github-menu
spa-developers-menu

When you hover over the smaller one, and go below the last

  • item there, the ContentGroup will not hide, but you can actually click on invisible
  • item that belongs to the second ContentGroup, which should be not active.
    spa-github-menu-li-tools

    Maybe making inactive ContentGroup hidden would solve this problem, but let me know if you could fix it, because it would be a pitty to leave it with it :)

    Thank you man!

    		•
    @yusinto
    Copy link
    Owner

    yusinto commented Sep 6, 2018

    Hey @jan-capiak I can reproduce the issue. I will take a look soon when I have time. Thanks for reporting!

    @yusinto
    Copy link
    Owner

    yusinto commented Sep 12, 2018

    @jan-capiak I've discovered this is a bug related to css-grids. The root component of react-site-nav is a css grid and if a content group contains another css grid, this problem occurs. If the content groups are all using flex, then this bug goes away!

    I'll need more time to fix this, but in the interim, perhaps use flex in your content group as a workaround. I'll keep you up to date.

    yusinto added a commit that referenced this issue Sep 13, 2018
    @yusinto
    Fixed issue #4 where contentgroups with differing height interfere wi…
    1d6fcd1 
    …th closing the nav. Support root nav item as a link. Added new background property to ContentGroup to support different background colours. Added new contentTop property to SiteNav so the moving div distance from root items can be adjusted.

Fixed issue #4 where contentgroups with differing height interfere with closing the nav.
Support root nav item as a link.
Added new background property to ContentGroup to support different background colours.
Added new contentTop property to SiteNav so the moving div distance from root items can be adjusted.
    @yusinto
    Copy link
    Owner

    yusinto commented Sep 13, 2018

    @jan-capiak this has been fixed in the latest release v0.2.7

    It turns out the overlapping content groups were the problem, not related to css-grid (that was a redherring). Please let me know if it works now! Thanks.

    @jan-capiak
    Copy link
    Author

    Hello @yusinto , its working now, great job, I guess we can close this issue now :) thank you

    @yusinto
    Copy link
    Owner

    yusinto commented Sep 14, 2018

    @jan-capiak cool! Closing this now.

    @yusinto yusinto closed this as completed Sep 14, 2018
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @yusinto @jan-capiak