-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port for database instance is not updated #147
Comments
Hello @androa 👋🏼 Thanks for using the plugin and reporting the issue. I'll take a look when I have time. Greetings 🖐🏼 |
Howdy @androa 🖐🏼 I assume you have a custom logging configuration to have JSON logs. Could you please share it with me? I need to reproduce that on my local machine. Even for better help, you may create a merge request on https://github.com/yusufugurozbek/testcontainers-demo with your configuration. Greetings |
This replicates the test setup for the issue yusufugurozbek/testcontainers-port-updater#147
Yep, that's right. This is the log configuration we run: https://github.com/navikt/rapids-and-rivers/blob/master/src/main/resources/logback.xml. Added a PR to your demo-repository with that (slightly simplified) setup. Testing with and without JSON-formatting, it is clearly the culprit. The plugin has worked marvels with this configuration for years. |
The new release (v1.1.2) should solve your issue. Please check the settings and mark your project logging format as JSON. Looking forward to hearing your feedback. |
Thank you! Tested it now and it seems to work now. But I'm not getting any notifications, even if it is checked off in the settings. |
I checked that and the notifications are working fine for me. My recommendations are:
Greetings 👋🏼 |
It was indeed the notification settings that was set to no popup. This seems to be the default when the plugin is installed. Thank you again. This plugin is one of the most time saving plugins out there 🚀 |
Describe the bug
The port does not get updated. The notification is not popping up either.
I've tried to figure out why and I can't understand anything else than that the IntelliJ
ConsoleFilterProvider
or thegetMaybeLocalDataSource()
is not firing correctly.To Reproduce
I run my tests which outputs this to the logs:
{"@timestamp":"2023-07-18T16:13:11.315968+02:00","@version":"1","message":"Database: jdbc:postgresql://localhost:32799/test (PostgreSQL 15.2)","logger_name":"org.flywaydb.core.internal.database.base.BaseDatabaseType","thread_name":"Test worker","level":"INFO","level_value":20000}
My datasource in IntelliJ is configured with this URL:
jdbc:postgresql://localhost:32791/test
.Expected behavior
The port to be updated.
Screenshots
IntelliJ version
The text was updated successfully, but these errors were encountered: