Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded #3

Merged
merged 3 commits into from
May 29, 2024
Merged

Upgraded #3

merged 3 commits into from
May 29, 2024

Conversation

Kolomona
Copy link
Contributor

I couldn't get this to compile using IntelliJ and JDK 22.0.1
Apparently lombok needed to be updated.

Then I kept getting UnrecognizedPropertyException errors regarding the medium tag. I added it as a String Type to the Podcast.java file. It seems to work.

The getPodcastsByMedium and GetPodcastsByTag test still fail with

com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "inPollingQueue" (class com.github.yusufyilmazfr.podcast4j.entity.Podcast)

I suspect a similar fix may correct their issues

Thank you for making this!

@yusufyilmazfr
Copy link
Owner

Thanks a lot @Kolomona, the Medium tag problem is already mentioned here: #2. You've fixed 2 problem, the first is JDK 22.0.1 and another is given second issue. I think i've to remove Lombok dependency, I used this client because it is easy while i was developing this client. Maybe I'll open new issue about this. Another problem is about UnrecognizedPropertyException, we don't have to throw any exception if there is a new field. I'll exclude this exception. Thanks again! ❤️ I'll try to generate a new podcast4j client after merge.

@yusufyilmazfr
Copy link
Owner

new client is available on central repository now! 🥳
https://repo1.maven.org/maven2/io/github/yusufyilmazfr/podcast4j/1.0.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants