-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuest.body value after passed to another Request #60
Comments
cc: @annevk |
I'm okay either way. I guess someone should measure the performance of doing piping if we are fine gating on that? |
Is this solved currently? I lost track. If it is not, it probably can be solved similarly to w3c/ServiceWorker#934 ? |
It's not yet solved, and it should be solved as same as w3c/ServiceWorker#934. |
What is the status of this issue? I missed it while merging in stream-based requests. |
annevk
pushed a commit
to whatwg/fetch
that referenced
this issue
Jan 27, 2017
Tests: #458. Fixes yutakahirano/fetch-with-streams#60.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At whatwg/fetch#61, we agreed that
req.bodyUsed
should be false ifreq
had null body, andreq.bodyUsed
should be true ifreq
had a non-null body.Anne proposed to introduce
obsolete flag
in order to makereq.body
null andreq.bodyUsed
true after passing the body, but it looks like anotherpassed flag
we replaced with ReadableStream.IsDisturbed. @jakearchibald's piping idea sounds cleaner to me and ideally it should work, but I'm not sure about its performance.Thoughts?
cc: @domenic @wanderview @tyoshino
The text was updated successfully, but these errors were encountered: