Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bodyWriter instead of letting body be a function #3

Closed
wants to merge 1 commit into from

Conversation

domenic
Copy link
Contributor

@domenic domenic commented Oct 31, 2014

See discussion in f4609c9 and w3c/ServiceWorker#413.

@yutakahirano
Copy link
Owner

Looks good for Request, but how about Response / ResponseInit? I'm a bit confused about the inconsistency of initialization ways between Request and Response. @annevk, can you tell me why?

@annevk
Copy link

annevk commented Nov 4, 2014

@yutakahirano well, typically, requests are about URLs and responses are about data. It seemed to make sense to match to make the common case convenient. Open to suggestions.

@domenic
Copy link
Contributor Author

domenic commented Nov 5, 2014

After thinking about this for a while I can't see a way to make it work great for Response and so I am retracting it. I posted to whatwg@whatwg.org to ask for any other options but unless there is a great idea I am OK with overloading the body option (in both cases) so that when given a function it exposes the writable stream.

https://readable-email.org/list/whatwg/topic/feedback-wanted-on-integrating-fetch-request-response-and-streams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants