fix compiler warnings (open-telemetry#1499)

* fix compiler warnings * format
yxue · Dec 5, 2022 · e8eafd9 · e8eafd9
1 parent 2b60051
commit e8eafd9
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h b/sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h
@@ -23,6 +23,7 @@ class AttributesProcessor
   // @returns The processed attributes
   virtual MetricAttributes process(
       const opentelemetry::common::KeyValueIterable &attributes) const noexcept = 0;
+  virtual ~AttributesProcessor()                                                = default;
 };
 
 /**

diff --git a/sdk/src/metrics/metric_reader.cc b/sdk/src/metrics/metric_reader.cc
@@ -14,7 +14,7 @@ namespace metrics
 {
 
 MetricReader::MetricReader(AggregationTemporality aggregation_temporality)
-    : aggregation_temporality_(aggregation_temporality), shutdown_(false), metric_producer_(nullptr)
+    : metric_producer_(nullptr), aggregation_temporality_(aggregation_temporality), shutdown_(false)
 {}
 
 void MetricReader::SetMetricProducer(MetricProducer *metric_producer)

diff --git a/sdk/src/metrics/state/sync_metric_storage.cc b/sdk/src/metrics/state/sync_metric_storage.cc
@@ -18,7 +18,6 @@ bool SyncMetricStorage::Collect(CollectorHandle *collector,
                                 nostd::function_ref<bool(MetricData)> callback) noexcept
 {
   opentelemetry::common::SystemTimestamp last_collection_ts = sdk_start_ts;
-  auto aggregation_temporarily = collector->GetAggregationTemporality();
 
   // Add the current delta metrics to `unreported metrics stash` for all the collectors,
   // this will also empty the delta metrics hashmap, and make it available for

diff --git a/sdk/test/metrics/async_metric_storage_test.cc b/sdk/test/metrics/async_metric_storage_test.cc
@@ -93,9 +93,7 @@ TEST_P(WritableMetricStorageTestFixture, TestAggregation)
   std::vector<std::shared_ptr<CollectorHandle>> collectors;
   collectors.push_back(collector);
   size_t count_attributes = 0;
-  long value              = 0;
 
-  MeasurementFetcher measurement_fetcher;
   opentelemetry::sdk::metrics::AsyncMetricStorage<long> storage(instr_desc, AggregationType::kSum,
                                                                 MeasurementFetcher::Fetcher,
                                                                 new DefaultAttributesProcessor());