Skip to content

Commit

Permalink
Merge pull request #5 from terrytangyuan/master
Browse files Browse the repository at this point in the history
merge from terrytangyuan/mxnet
  • Loading branch information
yanqingmen committed Dec 17, 2015
2 parents 805a542 + 2d87baf commit 05431f5
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 5 deletions.
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ matrix:
env: TASK=doc
- os: linux
env: TASK=r_test
- os: linux
env: TASK=scala_test

# dependent apt packages
addons:
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,4 @@ List of Contributors
* [Ye Zhou](https://github.com/zhouye)
* [Zhang Chen](https://github.com/zhangchen-qinyinghua)
* [Xianliang Wang](https://github.com/wangxianliang)
* [Junru Shao](https://github.com/yzgysjr)
3 changes: 3 additions & 0 deletions doc/build.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ various distributed filesystem such as HDFS/Amazon S3/...
- First copy [make/config.mk](../make/config.mk) to the project root, on which
any local modification will be ignored by git, then modify the according flags.

#### Building with Intel MKL Support
First, `source /path/to/intel/bin/compilervars.sh` to automatically set environment variables. Then, edit [make/config.mk](../make/config.mk), let `USE_BLAS = mkl`. `USE_INTEL_PATH = NONE` is usually not necessary to be modified.


## Python Package Installation

Expand Down
6 changes: 6 additions & 0 deletions include/mxnet/optimizer.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,15 @@
#include "./base.h"
#include "./resource.h"

#if DMLC_USE_CXX11
#include <mxnet/ndarray.h>
#endif

namespace mxnet {

#if !DMLC_USE_CXX11
class NDArray;
#endif

class Optimizer {
public:
Expand Down
1 change: 0 additions & 1 deletion src/optimizer/sgd-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ void call_sgd_update_gpu(RunContext ctx, TBlob weight, const TBlob grad,
#endif // MXNET_USE_CUDA

#if DMLC_USE_CXX11
#include <mxnet/ndarray.h>

class SGDOpt : public Optimizer {
public:
Expand Down
9 changes: 7 additions & 2 deletions tests/travis/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,17 @@ if [ ${TASK} == "scala_test" ]; then
mkdir -p ${CACHE_PREFIX}/data
ln -s ${CACHE_PREFIX}/data ${PWD}/data

cd scala-package
export JAVA_HOME=$(/usr/libexec/java_home)

if [ ${TRAVIS_OS_NAME} == "osx" ]; then
cd scala-package
export JAVA_HOME=$(/usr/libexec/java_home)
mvn clean package -P osx-x86_64
mvn integration-test -P osx-x86_64
fi
if [ ${TRAVIS_OS_NAME} == "linux" ]; then
mvn clean package -P linux-x86_64
mvn integration-test -P linux-x86_64
fi

exit 0
fi
Expand Down

0 comments on commit 05431f5

Please sign in to comment.