Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyrics #76

Closed
3 tasks done
noClaps opened this issue Jun 5, 2022 · 8 comments
Closed
3 tasks done

Lyrics #76

noClaps opened this issue Jun 5, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@noClaps
Copy link

noClaps commented Jun 5, 2022

Checklist

  • I've checked that there is no other issue about this feature request.
  • This issue contains only one feature request.
  • The title of this issue accurately describes the feature request.

Feature description

The app should have lyrics for songs, when available. It can be present on the music player screen, and accessible either by tapping the cover (Retro Music implementation), or in a section below the player (YT Music/Spotify implementation).

Why do you want this feature?

Being able to see the lyrics is a feature present in most music players.

Additional information

There's another music player, ViMusic, that displays lyrics to songs. Maybe you can use a similar approach to them to get lyrics? Another option is to use Genius, similar to how spotdl do it.

@noClaps noClaps added the enhancement New feature or request label Jun 5, 2022
@noClaps noClaps changed the title Lyrixs Lyrics Jun 5, 2022
@z-huang
Copy link
Owner

z-huang commented Jun 9, 2022

Maybe you can use a similar approach to them to get lyrics?

Yes, it's feasible.

@Reffler
Copy link

Reffler commented Sep 23, 2022

I also look forward for this feature! I'm loving the app so far

@z-huang
Copy link
Owner

z-huang commented Sep 24, 2022

This will be added along with the player redesign.

This was referenced Oct 17, 2022
z-huang added a commit that referenced this issue Oct 22, 2022
Note: experimental feature
@z-huang
Copy link
Owner

z-huang commented Oct 22, 2022

Overall feature completed. Additional features to be implemented:

  • Add an option to align lyrics left/center/right
  • Add an option to disable KuGou lyrics provider in privacy settings
  • Switch lyrics provider
  • Edit lyrics
  • Keep screen on when lyrics enabled

If interested, please try the debug version and report bugs.

@xmha97
Copy link
Contributor

xmha97 commented Oct 22, 2022

Thanks, everything works fine, but how can I copy the lyrics files? (.lrc)

@z-huang
Copy link
Owner

z-huang commented Oct 23, 2022

The lyrics are stored as string in the database, so you won't find them in the app's file directory. Maybe I can export them with SAF.

@z-huang
Copy link
Owner

z-huang commented Oct 23, 2022

Note: scrolling of the LyricsView isn't smooth enough and needs tweaking.

@z-huang z-huang mentioned this issue Oct 26, 2022
3 tasks
z-huang added a commit that referenced this issue Oct 26, 2022
@z-huang
Copy link
Owner

z-huang commented Oct 26, 2022

Now it should be smooth. Feedback welcomed.

z-huang added a commit that referenced this issue Oct 30, 2022
@z-huang z-huang closed this as completed Oct 30, 2022
@z-huang z-huang unpinned this issue Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants