Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spanish] Create strings.xml #120

Merged
merged 3 commits into from Jun 18, 2022
Merged

[Spanish] Create strings.xml #120

merged 3 commits into from Jun 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2022 •
edited by ghost
Loading

Addition of the Spanish (US) language.

@ghost ghost changed the title [Spanish] strings.xml created strings.xml spanish created Jun 17, 2022
@ghost ghost changed the title strings.xml spanish created [Spanish] Create strings.xml Jun 17, 2022
@z-huang z-huang mentioned this pull request Jun 18, 2022
Closed
@z-huang
Copy link
Owner

z-huang commented Jun 18, 2022 •
edited
Loading

Is this and #119 the same? Is es equal to es-US?

@ghost
Copy link
Author

ghost commented Jun 18, 2022

Is this and #119 the same? Is es equal to es-US?

Yes, they're the same.

z-huang
z-huang requested changes Jun 18, 2022
View reviewed changes
Copy link
Owner

@z-huang z-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line needs to be added.

app/src/main/res/values-es-rUS/strings.xml Show resolved Hide resolved
@z-huang
Copy link
Owner

z-huang commented Jun 18, 2022

Yes, they're the same.

Then I'll merge the one that passes the check first.

@z-huang
Copy link
Owner

z-huang commented Jun 18, 2022

Thanks!

@z-huang z-huang merged commit 6ca4014 into z-huang:dev Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@z-huang