Improved dialogs in the preferences #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
changed the title
|
Looks good! Thanks! |
thornySoap
pushed a commit
to thornySoap/InnerTune
that referenced
this pull request
Jul 16, 2024
Indonesian translation update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
first of all thanks for all your work spent onto the project, it's the best looking app for me for listening to music while having a lot of features included (love the proxy) :)
This PR will improve the design of the preference dialogs by using the
MaterialAlertDialogBuilderwhen showing preferences instead of using the preference dialogs by theandroidxlibrary since themateriallibrary doesn't have its own implementation of thePreferenceFragmentCompat.Affected preference dialogs are the dialog of the
ListPreferenceas well as theEditTextPreference.Old:
New:
Regards