Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Malayalam (India) translations #249

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

aaj013
Copy link
Contributor

@aaj013 aaj013 commented Sep 29, 2022

  • Created Malayalam translation using Android studio based on README instructions.
  • Added all translations.
  • Successfully built apk and also run on phone.

Tried to change language and check if everything appearing correctly, but failed to do so. Only content language/region is being changed.
Device: Oneplus 8T(IN)
Android version: OOS12.1

@z-huang
Copy link
Owner

z-huang commented Sep 29, 2022

I can see your translation.
image

Thank you for having builded successfully before opening the PR. Therefore, I can merge your PR quickly.

@z-huang z-huang merged commit f2760eb into z-huang:dev Sep 29, 2022
@aaj013
Copy link
Contributor Author

aaj013 commented Sep 29, 2022

I can see your translation.

How to change the language? I found only option to change Content language and region. Is that the same? Am I missing this option because of Android version incompatibility?

Thank you for having builded successfully before opening the PR. Therefore, I can merge your PR quickly.

Always glad to help. :)

@aaj013 aaj013 deleted the feature/add-malayalam-translation branch September 29, 2022 05:39
@z-huang
Copy link
Owner

z-huang commented Sep 29, 2022

How to change the language?

Change it in Android settings.

@aaj013
Copy link
Contributor Author

aaj013 commented Sep 29, 2022

Change it in Android settings.

Fine, will check it out. Still I would suggest an option within app to control the App language (may be an enhancement in future), just like in Newpipe. Default will be system language.

Screenshot_2022-09-29-11-55-08-65_ee8807d2de22f1831269d80920e33a3b

@z-huang
Copy link
Owner

z-huang commented Sep 29, 2022

It's a good idea. You can create an issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants