Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf/fix]: ✨ performance #240

Merged
merged 3 commits into from
Nov 12, 2022
Merged

[perf/fix]: ✨ performance #240

merged 3 commits into from
Nov 12, 2022

Conversation

ss-o
Copy link
Member

@ss-o ss-o commented Nov 12, 2022

Pull request template

Type of changes

  • CI
  • Bugfix
  • Feature
  • Generic maintenance tasks
  • Documentation content changes
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no URL changes)
  • Improving the performance of the project (not introducing new features)
  • Other (please describe):

Issue Number: N/A

What is the new behavior?

  • User/Device specific directories:

    • Global/Optional parameter specifications define where these files should be looked for by specifying one or more base directories relative to which files should be located. This allows for verifying/creating/setting user-preferred/default paths.
  • Project terms/words:

    • Correction/Collection of project terms/words to prevent namespace pollution. Used for docs/tests/automation and other maintenance/improvements.
  • Fix atpull ice-modifier:

    • Fix to correctly register atpull hooks during the exclamation mark expansion.

Does this introduce a breaking change?

  • Yes
  • No

ss-o added 3 commits November 12, 2022 11:34
Global/Optional paramater specifications which defines where these files should be looked for by defining one or more base directories relative to which files should be located. This allows to verify/create/set user prefered/default paths.
Correction/Collection of project terms/words to prevent namespace pollution. Used for docs/tests/automatation and other maintenace/improvements.
@ss-o ss-o requested a review from a team as a code owner November 12, 2022 15:44
@github-actions github-actions bot added the enhancement ✨ Enhancement of the code, not introducing new features. label Nov 12, 2022
@ss-o ss-o changed the title Minor next/fix [perf/fix]: ✨ performance Nov 12, 2022
@ss-o ss-o enabled auto-merge (squash) November 12, 2022 15:54
@ss-o ss-o disabled auto-merge November 12, 2022 15:54
@ss-o ss-o merged commit 04310b2 into z-shell:main Nov 12, 2022
@ss-o ss-o deleted the minor_next branch November 12, 2022 15:55
@github-actions
Copy link

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement ✨ Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant