Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept pull requests? #56

Closed
Andersos opened this issue Dec 24, 2014 · 10 comments
Closed

Accept pull requests? #56

Andersos opened this issue Dec 24, 2014 · 10 comments

Comments

@Andersos
Copy link

I was looking over the issues and was planning to send some pull requests but when i realized there were issues from 2011 I wanted to be sure they would be looked at before giving an attempt.

@josdejong
Copy link

+1 This is a great module but needs some improvements. Can we help?

@beporter
Copy link

Nothing worse than crickets from a maintainer. 😞

@Andersos
Copy link
Author

What if we just make a fork and name it jsonlint2?

@josdejong
Copy link

What if we just make a fork and name it jsonlint2?

Makes sense Anders.

@beporter
Copy link

It would be preferable if we could get the maintainer to add a few trusted people to this repo as collaborators to help manage to community and the code base in their place.

That would preserve all of the links out there, and the package install instructions. Fragmenting attention between here and a fork should be a last resort. (We may be there already though.)

@josdejong
Copy link

We can try to contact @zaach

@zaach
Copy link
Owner

zaach commented Aug 15, 2015

Hey folks! I'd love to add a trusted maintainer or two. Interested folks should submit a PR addressing one of the open issues. And yeah, please @ me for my attention– I had to file github notification bankruptcy a while back.

@josdejong
Copy link

Thanks for your reply @zaach. I'm afraid I have no time left to maintain more projects, sorry :(

honzajavorek added a commit to apiaryio/gavel.js that referenced this issue Jul 20, 2016
The jsonlint dependency taken from fork due to zaach/jsonlint#56.
It's the same solution we are using internally in Apiary.

Supersedes apiaryio/dredd#555. Inspired by
apiaryio/gavel2html#2.
@honzajavorek
Copy link

@zaach I'm working for Apiary. I'm maintainer of Dredd and Gavel.js projects, which depend on your jsonlint library. We also depend on it internally - Apiary is SaaS stack for designing HTTP APIs and our online Apiary Editor uses jsonlint.

Reading this issue, I understand you don't have time to maintain the package. Many people do forks with their own improvements and patching. We're actually already using @josdejong's fork of jsonlint.

When working on one issue, I went through some of the issues on the jsonlint repo and some of the PRs already issued... I realized we could give some love back and to help maintaining the library. Even if we do it with lazy pace, merging one PR per two weeks or sth like that, in long term it would be still better then no activity and no up-to-date official version, which is the current state. I discussed it internally within the company and it looks like we would be willing to do that! After all, linting JSONs is not that far from what we do :)

While it would be probably mainly me (and my colleague @JackuB) doing the work, to prevent lack of maintainer time and burnout, I'd prefer if we could take care of the library as a company rather as just me, a single person. At the same time, I don't want Apiary to "usurp" the thing, especially given we've been recently acquired by Oracle.

If you like the idea allowing us to continue with the development of the library, I propose you create a GitHub organization dedicated to the project and invite me and couple of my colleagues to the organization. You'd stay as the holy founding father, and especially as an administrator, with rights to kick us away in case you don't like what we do.

Also, I know you don't have time to maintain the project, but if we do this, it would be super helpful if you could "stay nearby", reacting on mentions as the last source of wisdom in case we have no idea how to do something or why was something done particular way in the past.

What do you think?

@prantlf
Copy link

prantlf commented May 19, 2019

@zaach, if you're still looking for additional maintainers, I offer you "my service" :-)

I needed some bugfixes and extensions to jsonlint and did them in my fork. I cherry-picked some changes from Greg Inman and Paul Vollmer and added mine. I released the changes as a new NPM module @prantlf/jsonlint. I'd be happy to contribute back to your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants