Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to json request #321

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Switch to json request #321

merged 1 commit into from
Jul 10, 2022

Conversation

bojihao
Copy link
Contributor

@bojihao bojihao commented Jul 10, 2022

No description provided.

@bojihao
Copy link
Contributor Author

bojihao commented Jul 10, 2022

resolves #320

@alandtse
Copy link
Collaborator

Thanks. Did you confirm this doesn't break something like standard login logout?

@alandtse
Copy link
Collaborator

You should only mark it as closing issues on relevant libraries. Timdorr's repo is a documentation library so merging this in won't "close" that issue for them.

May also close #316

@bojihao
Copy link
Contributor Author

bojihao commented Jul 10, 2022

Hi @alandtse , I've removed the links to other repos. I verified the change in the context of Home Assistant including the situation where access token is refreshed. By looking through the code I did not find anything that may break. It seems to me that the change does not affect login/logout, which invokes self.websession.get/post directly instead of the custom ones self.get/post.

@alandtse
Copy link
Collaborator

Ok. Great. Thanks for figuring this out and testing it.

@alandtse alandtse merged commit 5bf943d into zabuldon:dev Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants