Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BaseModel.php #6

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Update BaseModel.php #6

merged 1 commit into from
Jan 9, 2020

Conversation

gulaandrij
Copy link

convert nested arrays of objects to array too

@gulaandrij
Update BaseModel.php
c8e1bb0 
convert nested arrays of objects to array too
@zack6849
Copy link
Owner

zack6849 commented Jan 9, 2020

@gulaandrij I appreciate this PR, but more information would really be helpful.

This is a feature being added, not a bug fix, correct?
Thanks,

@zack6849 zack6849 self-assigned this Jan 9, 2020
@gulaandrij
Copy link
Author

For example, we have an Order object with an array of OrderItem items. When we try to call $order->toArray() it converts Order object and nested objects to an array but it skips converting nested arrays.

Examples:
image
image

@zack6849 zack6849 merged commit 0b3e09e into zack6849:master Jan 9, 2020
@zack6849 zack6849 added the bug label Jan 9, 2020
@gulaandrij gulaandrij deleted the patch-1 branch January 9, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zack6849 zack6849

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gulaandrij @zack6849