forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
suggest one-argument enum variant to fix type mismatch when applicable
Most notably, this will suggest `Some(x)` when the expected type was an Option<T> but we got an x: T. Resolves rust-lang#42764.
- Loading branch information
1 parent
f85579d
commit eac7410
Showing
3 changed files
with
66 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
enum DoubleOption<T> { | ||
FirstSome(T), | ||
AlternativeSome(T), | ||
None, | ||
} | ||
|
||
fn this_function_expects_a_double_option<T>(d: DoubleOption<T>) {} | ||
|
||
fn main() { | ||
let n: usize = 42; | ||
this_function_expects_a_double_option(n); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
error[E0308]: mismatched types | ||
--> $DIR/issue-42764.rs:21:43 | ||
| | ||
21 | this_function_expects_a_double_option(n); | ||
| ^ expected enum `DoubleOption`, found usize | ||
| | ||
= note: expected type `DoubleOption<_>` | ||
found type `usize` | ||
help: perhaps you meant to use a variant of the expected type | ||
| | ||
21 | this_function_expects_a_double_option(FirstSome(n)); | ||
| ^^^^^^^^^^^^ | ||
21 | this_function_expects_a_double_option(AlternativeSome(n)); | ||
| ^^^^^^^^^^^^^^^^^^ | ||
|
||
error: aborting due to previous error | ||
|