Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint and formating enhancement #3827

Merged
merged 7 commits into from
Apr 17, 2023
Merged

Conversation

soulsands
Copy link
Contributor

Hi zadam. this pr is about eslint and formating staff, and I shared a vscode setting.
Highly recommand using vscode for javascript development.
You can check the file .eslintrc.js for eslint config. Currently I turn off all the rules that throw exceptions.you can turn them on one by one to see the influence and decide to leave them on or off.
These tools really helps a lot, please check it.

Copy link
Owner

@zadam zadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the effort on this!

.eslintrc.js Outdated Show resolved Hide resolved
.eslintignore Outdated Show resolved Hide resolved
.husky/pre-commit Outdated Show resolved Hide resolved
@zadam
Copy link
Owner

zadam commented Apr 14, 2023

Highly recommand using vscode for javascript development.

Only people who didn't try IntelliJ / WebStorm can recommend VSCode ;-)

@soulsands
Copy link
Contributor Author

Highly recommand using vscode for javascript development.

Only people who didn't try IntelliJ / WebStorm can recommend VSCode ;-)

yeah I shouldn't mention that. that was a hasty advice haha. I have'nt tried webstorm in recent years though.

Anyway I just hope people can code in this project easily, getting rid of lint and style stuffs, saving enegy for necessary works.

By the way, when will the next version be released? I can't wait for it.

@soulsands soulsands requested a review from zadam April 15, 2023 01:53
@zadam
Copy link
Owner

zadam commented Apr 16, 2023

By the way, when will the next version be released? I can't wait for it.

Still several weeks for the first beta and the beta phase will be extra long this time around.

0.60 changes a lot of things for the #3682

@soulsands
Copy link
Contributor Author

Not sure if this request is appropriate, but would you consider releasing a patch version. The patch would include a number of fixes and performance enhancements. I'm working on Windows and haven't successfully packaged the server yet. Of course, if it takes too much time, please feel free to disregard it. @zadam

@zadam zadam merged commit af9ef83 into zadam:master Apr 17, 2023
@zadam
Copy link
Owner

zadam commented Apr 17, 2023

@soulsands not sure what you mean exactly. I will release 0.59.4 shortly and will keep releasing patch versions until 0.60 stable is released.

@soulsands
Copy link
Contributor Author

soulsands commented Apr 18, 2023

@soulsands not sure what you mean exactly. I will release 0.59.4 shortly and will keep releasing patch versions until 0.60 stable is released.

My bad, I thought the next release would be 0.60, my english expression has flaws.

@soulsands
Copy link
Contributor Author

@zadam Hi, I tried 0.59.4 and found it doesn't include my commits. I'm wondering if it was missed or intentionallyfor the next release. Personally I'm waiting for the persistent cache one actually, which would improve the browser-using experience a lot in poor network.

@zadam
Copy link
Owner

zadam commented Apr 18, 2023

The patch releases contain only small scale fixes. Your changes will be in 0.60, but it will take some time.

@soulsands
Copy link
Contributor Author

Thanks for you explaining patiently, I understand know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants