Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pale Moon 27.1+ support #43

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Pale Moon 27.1+ support #43

merged 1 commit into from
Feb 2, 2017

Conversation

JustOff
Copy link
Contributor

@JustOff JustOff commented Feb 2, 2017

@zaidka zaidka merged commit 4e201fd into zaidka:master Feb 2, 2017
@JustOff
Copy link
Contributor Author

JustOff commented Feb 3, 2017

Thank you for supporting Pale Moon! I would be most grateful if you could also publish updated version on AMO.

@zaidka
Copy link
Owner

zaidka commented Feb 16, 2017

The current code base is a dead-end for Firefox and I'm rewriting cliget using Web Extensions. Does/will Pale Moon support Web Extensions? How about e10s (e10s broke cliget)? I'm asking because I need to decide whether I need to keep two code bases or move to Web Extensions entirely.

@JustOff
Copy link
Contributor Author

JustOff commented Feb 17, 2017

Pale Moon does not use e10s and currently there are no plans to support WebExtensions. If you would be so kind to support classic version of cliget I can assist you to host it at https://addons.palemoon.org/ (the signing of extensions is not required).

@Massimo-B
Copy link

Any news about that? I'm missing Cliget since migrating to Palemoon, though some old Cliget version was working for a while on Palemoon.

@Massimo-B
Copy link

Could you at least provide some .xpi build here? As supporting Palemoon is a major milestone, no matter how tiny the change was.

@zaidka
Copy link
Owner

zaidka commented Mar 23, 2017

There has been some fairly big changes since the last release that I need to review and clean up. Sorry but I just haven't had any time to work on it due to being overwhelmed with other work. I intend to get to it soon.

@Massimo-B
Copy link

Thank you very much. However I tried building that XPI, fetched some nodejs and jpm first, but it fails like this:

$ pwd
/home/mb/src/other/cliget

$ ls -al
total 36K
drwxr-xr-x 1 mb mb  132 Mär 23 07:26 ./
drwxr-xr-x 1 mb mb  264 Mär 23 08:02 ../
drwxr-xr-x 1 mb mb   82 Mär 23 07:21 data/
drwxr-xr-x 1 mb mb  122 Mär 23 07:21 .git/
-rw-r--r-- 1 mb mb   15 Mär 23 07:21 .gitignore
-rw-r--r-- 1 mb mb   18 Mär 23 07:21 .jshintrc
drwxr-xr-x 1 mb mb   48 Mär 23 07:21 lib/
-rw-r--r-- 1 mb mb  17K Mär 23 07:21 LICENSE.txt
-rw-r--r-- 1 mb mb 2,8K Mär 23 07:21 package.json
-rw-r--r-- 1 mb mb 1,4K Mär 23 07:21 README.md
drwxr-xr-x 1 mb mb   24 Mär 23 07:21 test/

$ /home/mb/src/other/jpm/bin/jpm xpi
module.js:472
    throw err;
    ^

Error: Cannot find module 'object-assign'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/mb/src/other/jpm/bin/jpm:4:14)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants