Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "extra.vimrc" to allow user added Bundles #27

Conversation

riannucci
Copy link
Contributor

Allows the addition of bundles in an easy-to-merge way :) (For those of us who are tracking our personal changes in a git repo)

Allows the addition of bundles in an easy-to-merge way :)
@AdrienGiboire
Copy link
Collaborator

@jjungnickel is right. And Vundle block is not aimed to managed bundles. If you had to add bundles of your choice, there is a Bundles block :)

@zaiste: You may close this issue to keep the opened issues list clean :)

@zaiste
Copy link
Owner

zaiste commented Jul 16, 2012

@AdrienGiboire Thanks! I adore clean issue list ;)
@riannucci is local.vimrc ok for you?

@zaiste zaiste closed this Jul 16, 2012
@riannucci
Copy link
Contributor Author

Yup, sorry for the late response (was AFK from email last week). The issue with local.vimrc is that it comes before the Vundle initialization lines (before which Bundle statements will fail):

set rtp+=~/.vim/bundle/vundle/
call vundle#rc()

I added the extra.vimrc file after these so Vundle wil be full of happiness and joy.

@AdrienGiboire I'm not sure what you mean about the "Bundles" block?

In any event, I screwed up the block delimiters, so you won't want to take this commit as-is anyway. I was meaning to fix the pull request but I didn't get a chance to :(.

@AdrienGiboire
Copy link
Collaborator

The delimiters are fixed in the master.

The Bundles block is the one delimited in vimrc. If you want to set some configurations in .vimrc after the bundles, there is after.vimrc :)

" Load addidional configuration (ie to overwrite shorcuts) {{{
if filereadable(expand("~/.vim/after.vimrc"))
  source ~/.vim/after.vimrc
endif
" }}}

@riannucci
Copy link
Contributor Author

I'm... I'm still not sure what you mean by the bundles block:

$ grep -i bundles ~/.vim/vimrc
$

Anyhow, the idea was so people could add Bundle lines without having to worry about conflicts in vimrc when pulling.

The reason I added the extra.vimrc was to add new Bundle statements after Vundle is initialized, but before all the mappings in the vimrc, since bundles will do their own maps which can sometimes interfere with the ones in vimrc. With the before/after scheme, there's no way to load additional bundles without also potentially sacrificing some of the mappings in vimrc. If I add "Bundle" lines to before.vimrc, it doesn't work, b/c Vundle isn't initialized, and if I add them to after.vimrc, then they'll blow away the mappings in vimrc. Yes, I could 'fix' this by copy-pasting either the initialization code (which makes starting vim slower :/) or the mappings I want (which then means I'll potentially have to manually copy them on every merge), but that seemed unappealing.

If there's no general interest in this functionality, then that's fine, too :).

@AdrienGiboire
Copy link
Collaborator

I see. Well, it's more relevant that way, indeed.

@zaiste, we should reconsider his idea :)

PS: By Bundles, I meant Packages. My bad :)

@riannucci
Copy link
Contributor Author

I think I should have been more clear in my original pull. I forget that other people can read my mind ;-D

@AdrienGiboire
Copy link
Collaborator

@riannucci, maybe you should pull your request again? ;)

@riannucci
Copy link
Contributor Author

Requested again as pull 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants