Introduce a problematic DNS and ExternalDNS version with the fix #5604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This successfully blocks all ExternalDNS updates 💥 |
linki
force-pushed
the
broken-dns-record
branch
from
d326182
to
9ad49d1
Compare
linki
force-pushed
the
broken-dns-record
branch
from
9ad49d1
to
5d349a2
Compare
|
Now trying the same with an ExternalDNS version that should tolerate some broken records. This is hopefully green. |
linki
changed the title
|
So this is green now. It means a single broken record doesn't block ExternalDNS and hence it passes all e2e tests. We should try to get kubernetes-sigs/external-dns#1209 merged or run a fork. |
|
As discussed let's go ahead with our internally released version from kubernetes-sigs/external-dns@a18bf2b which includes kubernetes-sigs/external-dns#1209. Dropping the |
|
👍 |
1 similar comment
|
👍 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add a Service of
Type: LoadBalancergiving it a DNS name that ExternalDNS has problems with (as ofv0.13.1, it might be fixed in later versions)The idea is that DNS should be pretty broken when running e2e tests. Then we can see if introducing #5602 makes sure to ignore the bad record.