Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for additional properties, eg. IdleTimeout of load balancer #440

Merged
merged 2 commits into from
Jan 30, 2017
Merged

Support for additional properties, eg. IdleTimeout of load balancer #440

merged 2 commits into from
Jan 30, 2017

Conversation

grzegorzjeziorski
Copy link
Contributor

@coveralls
Copy link

coveralls commented Jan 26, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 89.953% when pulling c1e5ae0 on grzegorzjeziorski:master into cad98c5 on zalando-stups:master.

@mirzali mirzali mentioned this pull request Jan 26, 2017
Closed
@hjacobs
Copy link
Contributor

hjacobs commented Jan 26, 2017 •
edited
Loading

Did you test with the empty {}? Did you create a stack with it?

@coveralls
Copy link

coveralls commented Jan 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 89.953% when pulling 228176a on grzegorzjeziorski:master into cad98c5 on zalando-stups:master.

@grzegorzjeziorski
Copy link
Contributor Author

Should be fixed now. I tested both variants, with and without a property set.

@hjacobs
Copy link
Contributor

hjacobs commented Jan 27, 2017

👍

@jmcs
Copy link
Member

jmcs commented Jan 30, 2017

👍

@hjacobs hjacobs merged commit 1412cd9 into zalando-stups:master Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcs jmcs Awaiting requested review from jmcs

@rafaelcaricio rafaelcaricio Awaiting requested review from rafaelcaricio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grzegorzjeziorski @coveralls @hjacobs @jmcs