Refactored get_load_balancer_name to be used when getting stack health #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 157a2a7 on arjunrn:master into ** on zalando-stups:master**. |
|
@rafaelcaricio @jmcs @hjacobs Could I get some feedback on this. We want to use this in our deployment pipelines and we are waiting for the feature to be merge. |
|
Thanks for the PR! 😄 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when getting stack health through
senza healththe LB metrics cannot be fetched for stacks with long application names. This is because the application name is truncated when creating the load balancer. However in thehealthcommand the name truncation is not performed which means the metrics are not fetched correctly. This PR moves the truncation function to theutilspackage so that it can be used in theclimodule as well as theelbmodule.