ARUHA-2372 Store event disk size stats from nakadi #1073

antban · 2019-06-21T11:27:53Z

ARUHA-2372 Store event disk size stats from nakadi

src/main/resources/disk_usage_event_type.json

v-stepanov · 2019-06-21T12:03:05Z

@antban code looks good.
But I think KafkaTopicRepository.getSizeStats() and DiskUsageStatsJob need tests.

src/main/java/org/zalando/nakadi/service/job/DiskUsageStatsJob.java

v-stepanov · 2019-06-24T09:41:15Z

src/test/java/org/zalando/nakadi/service/job/DiskUsageStatsJobTest.java

+        final Map<String, Long> actualResult = job.loadDiskUsage();
+        assertEquals(expectedResult, actualResult);
+    }
+}


you can configure your IDE to add that automatically

v-stepanov · 2019-06-24T09:53:26Z

src/main/java/org/zalando/nakadi/repository/kafka/KafkaZookeeper.java

+
+import java.util.List;
+
+public class KafkaZookeeper {


Looks more like BubukuZookeeper :)

v-stepanov · 2019-06-24T09:57:14Z

@antban
Everything looks good. Fix that super major problem with endline at the end of file and I will approve.

v-stepanov · 2019-06-24T12:05:19Z

👍

antban · 2019-06-25T13:23:15Z

👍

antban added 2 commits June 21, 2019 12:00

ARUHA-2372 Create job to publish event type stats report

c906c6e

ARUHA-2372 Create job to publish event type stats report

4598dcf

v-stepanov reviewed Jun 21, 2019

View reviewed changes

src/main/resources/disk_usage_event_type.json Outdated Show resolved Hide resolved

ARUHA-2372 Create unit test for data size job

4212a36

v-stepanov reviewed Jun 21, 2019

View reviewed changes

src/main/java/org/zalando/nakadi/service/job/DiskUsageStatsJob.java Outdated Show resolved Hide resolved

ARUHA-2372 Add tests as requested on review

99de3d7

v-stepanov reviewed Jun 24, 2019

View reviewed changes

ARUHA-2372 Remove absence of newline ))

36ba315

antban merged commit 753677f into master Jun 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARUHA-2372 Store event disk size stats from nakadi #1073

ARUHA-2372 Store event disk size stats from nakadi #1073

antban commented Jun 21, 2019

v-stepanov commented Jun 21, 2019

v-stepanov Jun 24, 2019

v-stepanov Jun 24, 2019

v-stepanov Jun 24, 2019

v-stepanov commented Jun 24, 2019 •

edited

Loading

v-stepanov commented Jun 24, 2019

antban commented Jun 25, 2019

ARUHA-2372 Store event disk size stats from nakadi #1073

ARUHA-2372 Store event disk size stats from nakadi #1073

Conversation

antban commented Jun 21, 2019

v-stepanov commented Jun 21, 2019

v-stepanov Jun 24, 2019

Choose a reason for hiding this comment

v-stepanov Jun 24, 2019

Choose a reason for hiding this comment

v-stepanov Jun 24, 2019

Choose a reason for hiding this comment

v-stepanov commented Jun 24, 2019 • edited Loading

v-stepanov commented Jun 24, 2019

antban commented Jun 25, 2019

v-stepanov commented Jun 24, 2019 •

edited

Loading