Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

aruha-1203: changelog #771

Merged
merged 3 commits into from
Nov 1, 2017
Merged

aruha-1203: changelog #771

merged 3 commits into from
Nov 1, 2017

Conversation

adyach
Copy link
Member

@adyach adyach commented Nov 1, 2017

aruha-1203: changelog

aruha-1203: changelog
CHANGELOG.md Outdated
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [2.2.8] - 2017-11-01
- Massive topic deletion while switching timelines is now made with small interval between deletions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be additional header like ### Fixed or ### Changed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov-io
Copy link

codecov-io commented Nov 1, 2017

Codecov Report

Merging #771 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #771      +/-   ##
===========================================
- Coverage     53.92%   53.9%   -0.03%     
+ Complexity     1492    1491       -1     
===========================================
  Files           294     294              
  Lines          8213    8213              
  Branches        715     715              
===========================================
- Hits           4429    4427       -2     
- Misses         3538    3539       +1     
- Partials        246     247       +1
Impacted Files Coverage Δ Complexity Δ
...n/java/org/zalando/nakadi/service/EventStream.java 86.84% <0%> (-2.64%) 26% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c168f31...40a9425. Read the comment docs.

aruha-1203: fixed block
@adyach
Copy link
Member Author

adyach commented Nov 1, 2017

👍

CHANGELOG.md Outdated
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [2.2.8] - 2017-11-01
### Fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for annoying but can you please add an empty line between version number and Fixed - to keep the same style for the whole file.

aruha-1203: newline
@adyach
Copy link
Member Author

adyach commented Nov 1, 2017

👍

1 similar comment
@v-stepanov
Copy link
Contributor

👍

@adyach adyach merged commit c2f553f into master Nov 1, 2017
@adyach adyach deleted the adyach-patch-2 branch December 12, 2017 08:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants