Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Support Running Sidecar With a Command #2448

Closed
tabbyl21 opened this issue Oct 17, 2023 · 3 comments
Closed

Feature Request: Support Running Sidecar With a Command #2448

tabbyl21 opened this issue Oct 17, 2023 · 3 comments

Comments

@tabbyl21
Copy link
Contributor

Hi, I would like to support running a sidecar using a command. This is useful in the case that the container being run as a sidecar does not have an entry point and needs to be run explicitly using a command.

Here are my answers to the requested questions:

  • I am using the latest operator image.
  • I am running Zalando on GKE and kind as of now.
  • I am not running it in production presently.
  • I am using the latest operator image.
  • This is a feature request

I have run the change on my own fork, it is a two liner change. :)
tabbyl21 added a commit to tabbyl21/postgres-operator that referenced this issue Oct 17, 2023
@tabbyl21
Feat: Support Running Sidecard with a Command.
79d9284 
This PR addresses issue zalando#2448 . Some containers may not have entry points, if this is the case they would need to be run using a command. This change extends the definition of sidecar so that there is an optional command field. If the field is present then the container will be run using that command. This is a two line change that is fully backward compatible.
@tabbyl21 tabbyl21 mentioned this issue Oct 17, 2023
Merged
@tabbyl21
Copy link
Contributor Author

PR with required changes: #2449

@mhaley-tignis mhaley-tignis mentioned this issue Nov 3, 2023
Open
@kamenskiyyyy
Copy link

Any updates?

@seppelucas seppelucas mentioned this issue Nov 1, 2024
Open
FxKu pushed a commit that referenced this issue Dec 23, 2024
@tabbyl21
Feat: Support Running Sidecar with a Command. (#2449)
b276cd2 
* Feat: Support Running Sidecard with a Command.

This PR addresses issue #2448 . Some containers may not have entry points, if this is the case they would need to be run using a command. This change extends the definition of sidecar so that there is an optional command field. If the field is present then the container will be run using that command. This is a two line change that is fully backward compatible.
@FxKu
Copy link
Member

FxKu commented Dec 23, 2024

#2449 has been merged

@FxKu FxKu closed this as completed Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FxKu @tabbyl21 @kamenskiyyyy