Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace glide with Go modules #544

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Replace glide with Go modules #544

merged 2 commits into from
Oct 2, 2019

Conversation

erthalion
Copy link
Contributor

Work in progress, but I guess it would be nice to have.

@FxKu
Copy link
Member

FxKu commented May 14, 2019

resolves #148

@sdudoladov sdudoladov modified the milestone: v1.2 May 31, 2019
@sdudoladov
Copy link
Member

I found the original module proposal helpful to understand the modules' system while reviewing the operator's kubectl plugin (it switched from Glide to modules recently )

@FxKu
Copy link
Member

FxKu commented Aug 27, 2019

@erthalion could you rebase? Our test pipeline in the master branch is currently failing because the new kubectl-pg plugin needs GO111MODULE=on. Maybe this is a good moment for the operator to switch to Go modules, too.

@FxKu
Copy link
Member

FxKu commented Aug 30, 2019

A change in the code-generator source code made me change the package/directory name from acid.zalan.do to acidzalando. However, the group name remains the same (with dots).

I created a PR in the codegen repo. If they consider changing it back we could also switch back and not break things.

@FxKu FxKu added this to the v1.3 milestone Sep 2, 2019
@FxKu FxKu mentioned this pull request Sep 2, 2019
@sdudoladov
Copy link
Member

A change in the code-generator source code made me change the package/directory name from acid.zalan.do to acidzalando.

What impact did similar renaming have on other operators that depend on the code generator ?
if someone uses the renamed API the name change will break their code ?

@sdudoladov
Copy link
Member

FYI go 1.13 was released, it changes the way modules are configured

@FxKu
Copy link
Member

FxKu commented Sep 6, 2019

Looks like they are going to fix it, so we can leave the package name as it was before. Will update the PR, when it's merged on the code-generator side.

@FxKu FxKu force-pushed the feature/go-modules branch 2 times, most recently from ce88b89 to 110989f Compare September 24, 2019 14:19
Makefile Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
hack/update-codegen.sh Outdated Show resolved Hide resolved
pkg/controller/postgresql.go Show resolved Hide resolved
@sdudoladov
Copy link
Member

👍

@FxKu FxKu changed the title [WIP] An attempt to build with modules Replace glide with Go modules Oct 2, 2019
@FxKu
Copy link
Member

FxKu commented Oct 2, 2019

👍

1 similar comment
@sdudoladov
Copy link
Member

👍

@FxKu FxKu merged commit baae188 into master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants