OpenTracing support #595
Merged
OpenTracing support #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge is blocked by zalando/opentracing-toolbox#204 which in turn requires opentracing/opentracing-java#314 ⌛ |
riptide-opentracing/src/main/java/org/zalando/riptide/opentracing/span/ErrorSpanDecorator.java
Outdated
Show resolved
Hide resolved
...t-autoconfigure/src/main/java/org/zalando/riptide/autoconfigure/DefaultRiptideRegistrar.java
Outdated
Show resolved
Hide resolved
lmineiro
reviewed
Feb 26, 2019
riptide-opentracing/README.md
Outdated
| If you still want to enable it, you can do so by just registering the missing span decorator: | ||
|
|
||
| ```java | ||
| new OpenTracingPlguin(tracer) |
There was a problem hiding this comment.
typo: s/OpenTracingPlguin/OpenTracingPlugin
| return extract(template, arguments.getUriVariables()); | ||
| } | ||
|
|
||
| @Hack("Pretty dirty, but I couldn't find any other way...") |
...t-autoconfigure/src/main/java/org/zalando/riptide/autoconfigure/DefaultRiptideRegistrar.java
Outdated
Show resolved
Hide resolved
pc-alves
reviewed
Feb 28, 2019
pc-alves
reviewed
Feb 28, 2019
|
I should add a test that verifies that an error response that is retried and eventually succeeds is not counted as an error. The first attempt should though. |
|
Retries should still use the |
|
Alright, that works then. Thanks for the info! |
whiskeysierra
force-pushed
the
feature/opentracing
branch
3 times, most recently
from
2123c7f to
28486f6
Compare
whiskeysierra
force-pushed
the
feature/opentracing
branch
3 times, most recently
from
938f275 to
4a77084
Compare
whiskeysierra
force-pushed
the
feature/opentracing
branch
from
4a77084 to
6b7442f
Compare
whiskeysierra
requested review from
AlexanderYastrebov and
patandrick
as code owners
whiskeysierra
force-pushed
the
feature/opentracing
branch
2 times, most recently
from
b536e82 to
6d2929d
Compare
| [](https://travis-ci.org/zalando/riptide) | ||
| [](https://coveralls.io/r/zalando/riptide) | ||
| [](https://www.codacy.com/app/whiskeysierra/riptide) | ||
| [](http://www.javadoc.io/doc/org.zalando/riptide-metrics) |
whiskeysierra
force-pushed
the
feature/opentracing
branch
from
6d2929d to
fced0a5
Compare
|
👍 |
lukasniemeier-zalando
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to manage client span(s), decorate spans and inject the span context into requests.
Motivation and Context
#509
Types of changes
Checklist: