filters/auth: add grant cookie encoder #2953
Conversation
| @@ -12,6 +12,33 @@ import ( | |||
| "golang.org/x/oauth2" | |||
| ) | |||
|
|
|||
| type CookieEncoder interface { | |||
There was a problem hiding this comment.
Do we want cookie encoder or a generic token encoder that works with http.Response and may encode/extract token into/from cookie or e.g. headers?
There was a problem hiding this comment.
The existing Oauth2 approach here is designed to work with a cookie. Cookie-specific is fine for us unless you think it can be used somewhere else
There was a problem hiding this comment.
@AtorVdm I've updated CookieEncoder interface, please check if its suitable for the implementation you have in mind.
There was a problem hiding this comment.
Had a discussion with @AlexanderYastrebov. This works for us! If this is left as-is - we will implement our own compression on top. Another option is if you can split the cookie into multiple ones based on cookie max size param (can be defined). Either way this PR would be a prerequisite for this so I think it's good to get it merged.
AlexanderYastrebov
force-pushed
the
filters/auth/grant-cookie-encoder
branch
from
8e67ae3 to
5f8ce1a
Compare
AlexanderYastrebov
added
the
major
AlexanderYastrebov
force-pushed
the
filters/auth/grant-cookie-encoder
branch
5 times, most recently
from
e42a740 to
72b043f
Compare
AlexanderYastrebov
force-pushed
the
filters/auth/grant-cookie-encoder
branch
from
72b043f to
af10778
Compare
AlexanderYastrebov
force-pushed
the
filters/auth/grant-cookie-encoder
branch
2 times, most recently
from
88d4663 to
2a860d2
Compare
Add CookerEncoder interface to allow custom implementation of grant cookie encoding. For example custom implementation may store token value in some permanent key-value storage and encode key into the cookie. Another implementation may encode token value into multiple cookies. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Export EncryptedCookieEncoder and decouple it from OAuthConfig. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
filters/auth/grant-cookie-encoder
branch
from
2a860d2 to
54a3e3d
Compare
|
👍 |
|
👍 |
Add CookerEncoder interface to allow custom implementation of grant cookie encoding.
For example custom implementation may store token value in some permanent key-value storage and encode key into the cookie.
Another implementation may encode token value into multiple cookies.