metrics: add start label for prometheus counters #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
the
major
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
May 30, 2024
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
May 30, 2024
szuecs
reviewed
May 30, 2024
|
👍 |
Add start label to each counter with the value of counter creation timestamp as unix nanoseconds. This enables OpenTelemetry cumulative temporality, see https://opentelemetry.io/docs/specs/otel/metrics/data-model/#temporality Example: ``` ~$ curl -s localhost:9911/metrics | grep host_count # HELP skipper_serve_host_count Total number of requests of serving a host. # TYPE skipper_serve_host_count counter skipper_serve_host_count{code="200",host="bar_test",method="GET",start="1717066533598500794"} 1 skipper_serve_host_count{code="200",host="foo_test",method="GET",start="1717066538031805059"} 2 ``` Fixes #3087 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
metrics/prometheus_counter_start
branch
from
bdb6068
to
8b786c3
Compare
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
May 31, 2024
|
👍 |
1 similar comment
|
👍 |
This was referenced Jun 6, 2024
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jun 11, 2024
See zalando/skipper#3089 for details. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Jul 19, 2024
Add start label to each counter with the value of counter creation timestamp as unix nanoseconds. This enables OpenTelemetry cumulative temporality, see https://opentelemetry.io/docs/specs/otel/metrics/data-model/#temporality Example: ``` ~$ curl -s localhost:9911/metrics | grep host_count # HELP skipper_serve_host_count Total number of requests of serving a host. # TYPE skipper_serve_host_count counter skipper_serve_host_count{code="200",host="bar_test",method="GET",start="1717066533598500794"} 1 skipper_serve_host_count{code="200",host="foo_test",method="GET",start="1717066538031805059"} 2 ``` Fixes zalando#3087 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add start label to each counter with the value of counter creation timestamp as unix nanoseconds.
This enables OpenTelemetry cumulative temporality, see https://opentelemetry.io/docs/specs/otel/metrics/data-model/#temporality
Example:
Fixes #3087