enable hourly log ship mode #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
commented
Sep 11, 2024
hughcapet
reviewed
Sep 16, 2024
Co-authored-by: Polina Bungina <27892524+hughcapet@users.noreply.github.com>
hughcapet
reviewed
Sep 16, 2024
Co-authored-by: Polina Bungina <27892524+hughcapet@users.noreply.github.com>
hughcapet
reviewed
Sep 16, 2024
Co-authored-by: Polina Bungina <27892524+hughcapet@users.noreply.github.com>
hughcapet
reviewed
Sep 16, 2024
hughcapet
reviewed
Sep 20, 2024
hughcapet
force-pushed
the
hourly-logs
branch
from
4c050f7
to
d216caf
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to check in configure_spilo script if the provided schedule contains a / in the second position of the cron schedule. We then set an environment variable to be used in other places to decide on the log file names and Postgre's log_rotation_age.
Open questions:
does it actually work? Especially the post_init part. Still need to test.works. Test addedis there a better way than using an extra env variable?Env var is fine. It's actually easier to just set a flag.more flexibility on different log rotations?For now we decided to only distinguish between daily and hourly.Disclaimer: If somebody switches from daily to hourly format between 1am - 12pm one will have a gap of logs on S3.