Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set AWS_S3_FORCE_PATH_STYLE accordingly #670

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Dec 2, 2021

WAL-G will not work if we use our own endpoint that only supports path convention but AWS_S3_FORCE_PATH_STYLE is not set. This patch ensures that WAL-G and WAL-E will use the same convention.

Also add support to WALE_S3_ENDPOINT with convention other than path.

Signed-off-by: 胡玮文 huww98@outlook.com

@huww98 huww98 force-pushed the auto_force_path_style branch from 1a11890 to 65e2a73 Compare December 2, 2021 08:20
WAL-G will not work if we use our own endpoint that only supports path
convention but AWS_S3_FORCE_PATH_STYLE is not set. This patch ensures
that WAL-G and WAL-E will use the same convention.

Also add support to WALE_S3_ENDPOINT with convention other than path.

Signed-off-by: 胡玮文 <huww98@outlook.com>
@FxKu
Copy link
Member

FxKu commented Dec 6, 2021

👍

1 similar comment
@CyberDem0n
Copy link
Contributor

👍

@CyberDem0n CyberDem0n merged commit c41394b into zalando:master Dec 6, 2021
christoph-heiss pushed a commit to cybertec-postgresql/spilo that referenced this pull request Mar 29, 2022
WAL-G will not work if we use our own endpoint that only supports path convention but AWS_S3_FORCE_PATH_STYLE is not set. This patch ensures that WAL-G and WAL-E will use the same convention.

Also add support to WALE_S3_ENDPOINT with convention other than path.
zer0def pushed a commit to zer0def/spilo that referenced this pull request May 28, 2022
WAL-G will not work if we use our own endpoint that only supports path convention but AWS_S3_FORCE_PATH_STYLE is not set. This patch ensures that WAL-G and WAL-E will use the same convention.

Also add support to WALE_S3_ENDPOINT with convention other than path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants