Patroni 2.1.4 #737
Merged
Patroni 2.1.4 #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2022 10:43
- allow starting etcd on non-x86 platforms - refactor get_dcs_config()
sdudoladov
reviewed
Jun 13, 2022
| with open(cgroup_v2_memory_limit_path) as f: | ||
| try: | ||
| os_memory_mb = int(f.read()) / 1048576 | ||
| except Exception: # there could be "max" |
There was a problem hiding this comment.
what does the phrase
there could be "max"
mean here ?
To me the code reads like If there is any exception, pretend there is no limit on os_memory_mb by setting it to the max possible value
There was a problem hiding this comment.
"max", literally, a string.
There was a problem hiding this comment.
oh now I understand.
can you change the comment to
string literal "max" is a possible value
?
added 2 commits
June 16, 2022 14:48
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_dcs_config()functionClose #736, #726