Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds workflow for multiarch builds (linux/amd64, linux/arm64) being published to ghcr.io #790

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

mmoscher
Copy link
Contributor

@mmoscher mmoscher commented Oct 13, 2022

Changelog

  • introduces new GHA workflow to build and publish spilo multiarch images on ghcr.io. Workflow is triggered on tag creation.
  • currently linux/amd64 and linux/arm64 images are built
  • linux/amd64 build is tested using postgres-appliance/tests/test_spilo.sh
  • Note the linux/arm64 takes much more time, due to emulation, then the linux/amd64 build (7 vs. 120min)

Changes

  • adds GHA workflow .github/workflows/publish-ghcr-container.yaml
  • extends postgres-appliance/tests/docker-compose.yml to allow spilo image definition using environment variable, cf. postgres-appliance/tests/README
  • adds small section in the README mentioning that multiarch builds can be found on ghcr.io

Tests

Tests were done by tagging the forked repo. Tag p1-2 was successful.

Follow-Up:

  • wal-g multiarch builds are now available. Thus, Add build support on non-amd64 platforms #664 can be reverted and additional self-builds can be omitted. Finally, the arm64 build-time should decrease enormously. (useless if switch to postgresql 15 is done)

mmoscher and others added 2 commits October 13, 2022 21:55
* first darft for workflow

* extends docker-compose for spilo-testing to accept image name via ENV; extends workflow

* adds newline
@mmoscher mmoscher mentioned this pull request Oct 13, 2022
@mmoscher mmoscher marked this pull request as ready for review October 14, 2022 08:45
@mmoscher
Copy link
Contributor Author

@CyberDem0n can you have a look on the follow-up? If you think it's a valid solution, I'll file another PR.

README.rst Outdated Show resolved Hide resolved
postgres-appliance/tests/README Outdated Show resolved Hide resolved
.github/workflows/publish-ghcr-container.yaml Outdated Show resolved Hide resolved
@hughcapet
Copy link
Member

As for the follow-up, it is a valid solution but only unless feature/postgresql-15 is merged. We have recently migrated to Ubuntu 22.04 there and will actually build wal-g for both platforms.

Co-authored-by: Polina Bungina <bungina@gmail.com>
@mmoscher
Copy link
Contributor Author

As for the follow-up, it is a valid solution but only unless feature/postgresql-15 is merged. We have recently migrated to Ubuntu 22.04 there and will actually build wal-g for both platforms.

thanks for the info. To this end it sounds more like unnecessary work and I would leave it as is

@mmoscher mmoscher requested a review from hughcapet October 18, 2022 19:27
@mmoscher
Copy link
Contributor Author

@hughcapet suggested changes are made. Please have a re-review :)

@Jan-M
Copy link
Member

Jan-M commented Oct 21, 2022

@mmoscher von Aachener zu Aachener - great work. thanks for helping out.

@Jan-M
Copy link
Member

Jan-M commented Oct 21, 2022

👍

1 similar comment
@hughcapet
Copy link
Member

👍

@hughcapet hughcapet merged commit 1283fae into zalando:master Oct 24, 2022
@mmoscher
Copy link
Contributor Author

Thank's @Jan-M & @hughcapet =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants