-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds workflow for multiarch builds (linux/amd64, linux/arm64) being published to ghcr.io #790
Conversation
* first darft for workflow * extends docker-compose for spilo-testing to accept image name via ENV; extends workflow * adds newline
@CyberDem0n can you have a look on the follow-up? If you think it's a valid solution, I'll file another PR. |
As for the follow-up, it is a valid solution but only unless feature/postgresql-15 is merged. We have recently migrated to Ubuntu 22.04 there and will actually build wal-g for both platforms. |
Co-authored-by: Polina Bungina <bungina@gmail.com>
thanks for the info. To this end it sounds more like unnecessary work and I would leave it as is |
@hughcapet suggested changes are made. Please have a re-review :) |
@mmoscher von Aachener zu Aachener - great work. thanks for helping out. |
👍 |
1 similar comment
👍 |
Thank's @Jan-M & @hughcapet =) |
Changelog
Changes
Tests
Tests were done by tagging the forked repo. Tag
p1-2
was successful.Follow-Up:
wal-g multiarch builds are now available. Thus, Add build support on non-amd64 platforms #664 can be reverted and additional self-builds can be omitted. Finally, the arm64 build-time should decrease enormously.(useless if switch to postgresql 15 is done)