This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 140
feat: use keep alive agents for all fragment requests #282
Open
vigneshshanmugam
wants to merge
1
commit into
master
Choose a base branch
from
agent-keep-alive
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| 'use strict'; | ||
| const Agent = require('agentkeepalive'); | ||
| const { SOCKET_TTL } = require('./constants'); | ||
|
|
||
| class AgentStore { | ||
| constructor() { | ||
| const defaultAgentOpts = { socketActiveTTL: SOCKET_TTL }; | ||
| this.httpAgent = new Agent(defaultAgentOpts); | ||
| this.httpsAgent = new Agent.HttpsAgent(defaultAgentOpts); | ||
| } | ||
|
|
||
| getAgent(protocol) { | ||
| if (protocol === 'http:') { | ||
| return this.httpAgent; | ||
| } | ||
| return this.httpsAgent; | ||
| } | ||
| } | ||
|
|
||
| module.exports = new AgentStore(); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| 'use strict'; | ||
|
|
||
| /** | ||
| * Sets the timeout for the socket active time to live even if its in use. | ||
| */ | ||
| const SOCKET_TTL = 60 * 1000; | ||
|
|
||
| module.exports = { | ||
| SOCKET_TTL | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| 'use strict'; | ||
| const { parse } = require('url'); | ||
| const Agent = require('agentkeepalive'); | ||
| const assert = require('assert'); | ||
| const agentStore = require('../lib/agent-store'); | ||
|
|
||
| describe('Agent Store', () => { | ||
| it('should get https agent by default', () => { | ||
| const agent = agentStore.getAgent(); | ||
| assert(agent instanceof Agent.HttpsAgent); | ||
| }); | ||
|
|
||
| it('shoulg get http agent for http endpoints', () => { | ||
| const { protocol } = parse('http://test.com'); | ||
| const agent = agentStore.getAgent(protocol); | ||
| assert(agent instanceof Agent); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The socket ttl should be configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I was thinking the same as well, Plus have to come up with custom config options for circuit breaker pool settings + metrics + caching of fragments..
I will come up with some proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought for a while about this and I think we can customize all of the logic in a client library like perron(or create one specific for tailor - or give PR to perron to make it work). Perron already supports circuit breaker logic for clients and we can easy add cache specific logic as well..
I will give PR to perron once i have sometime to work on some features.