Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

allow setting annnotations on zalenium hub via helm chart #1006

Merged
merged 2 commits into from
Jul 19, 2019

Conversation

pschuermann
Copy link
Contributor

Description

This change will let you set annotations on the zalenium hub pod via helm chart values, see #1005

Motivation and Context

People use annotations to configure logging or monitoring e.g. configure sumologic log collector via annotation to read the zalenium hub logs

How Has This Been Tested?

Created an annotation and ran the helm chart locally on kubernetes.
Zalenium started and the annotation was set correctly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

align with value best practice
@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #1006 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1006   +/-   ##
=========================================
  Coverage     54.99%   54.99%           
  Complexity      675      675           
=========================================
  Files            58       58           
  Lines          4562     4562           
  Branches        429      429           
=========================================
  Hits           2509     2509           
  Misses         1818     1818           
  Partials        235      235

Copy link
Contributor

@arnaud-deprez arnaud-deprez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@diemol will merge it when he is back.

Copy link
Contributor

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @pschuermann!

@diemol
Copy link
Contributor

diemol commented Jul 19, 2019

Thanks for reviewing @arnaud-deprez!

@diemol diemol merged commit 2b04d03 into zalando:master Jul 19, 2019
@axozoid
Copy link
Contributor

axozoid commented Jul 22, 2019

Shouldn't we update the documentation to reflect this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants