This repository has been archived by the owner on Aug 27, 2024. It is now read-only.
Test and develop with postgres #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Sorry, still found places where we worked around sqlite/pg differences 😓 But I think that's it. |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using multiple database engines for developing, testing (both sqlite3) and production (postgres) can lead to subtle inconsistencies that aren't caught in unit/integration tests.
One example for this are
BIGINTcolumns. With sqlite these are stored asINTEGERand returned asnumber. With postgres they are stored asBIGINTand returned asstring.This PR adapts tests for postgres and provides a
docker-composefile to run both zappr and postgres locally.