Update Electron mock #158
Merged
Update Electron mock #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid send responseCallback, currently it's unnecessary for Electron
|
It looks |
| @@ -24,7 +24,7 @@ if ( | |||
| } | |||
|
|
|||
| if (window.isElectron) { | |||
| chrome.storage.local = { | |||
| chrome.storage.local = chrome.storage.local || { | |||
There was a problem hiding this comment.
Maybe just to wrap in if (chrome.storage.local) {} here? So it would be clearer for other contributors what is happening here.
|
@jhen0409, thanks! Would you add |
fixes copy:build:extension task for npm@2
|
It's passed on Travis. :) |
|
@jhen0409, any ideas why AppVeyor fails always at running tests for electron? I re-built the pr several times and always the same :-/ |
also add 5 attempts for find Redux tab
|
The last commit should fixed the problem, we need to wait loading time for Redux tab, and it looks very slow (9 seconds). 😂 |
|
Thanks a lot! |
This was referenced Sep 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chrome.runtime.sendMessageis related to electron-react-boilerplate/electron-react-boilerplate#266.The
chrome.storage.localis officially supported on v1.2.6, we can check it exists.