Am/chore/wasm support #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
force-pushed
the
am/chore/wasm-support
branch
2 times, most recently
from
8d00f63 to
67e2f40
Compare
IceTDrinker
force-pushed
the
am/chore/wasm-support
branch
2 times, most recently
from
407a434 to
aacd63a
Compare
IceTDrinker
force-pushed
the
am/chore/wasm-support
branch
from
b8ec9b8 to
8801de7
Compare
soonum
reviewed
Sep 4, 2024
There was a problem hiding this comment.
From a CI point of view everything is fine to me.
Just letting @tmontaigu for the final approval.
| @@ -12,7 +12,7 @@ jobs: | |||
| - name: Check first line | |||
| uses: gsactions/commit-message-checker@16fa2d5de096ae0d35626443bcd24f1e756cafee | |||
| with: | |||
| pattern: '^((feat|fix|chore|refactor|style|test|docs|doc)\(\w+\)\:) .+$' | |||
| pattern: '^((feat|fix|chore|refactor|style|test|docs|doc)(\([\w\-_]+\))?\!?\:) .+$' | |||
There was a problem hiding this comment.
Can you clarify the case you want to avoid ? If I undertand correctly you allow hypen and underscore within the parenthesis but not the exclamation mark right ?
What was the issue you've encountered ?
There was a problem hiding this comment.
it's something we did with Nico on the TFHE-rs repo to allow hypens, make the content of the parentheses optional and the ! is to allow indicating breaking change as conventional commits permits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapatation of #32 by @On0n0k1