-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding a Game of Life example #569
Conversation
e922819
to
0aa183e
Compare
0aa183e
to
3e912df
Compare
Hey guys, nothing priority here, but I did an application example with the Game of Life we've presented at the sprint demo. When you have some time, could you review it, please? There should be a blog about it as well, in the coming weeks, to explain a bit how it works, and show some use of CP |
Whoever wants to give it a review is welcome. Pinging maybe @BourgerieQuentin @umut-sahin @youben11 @rudy-6-4 ? |
dac450f
to
003b616
Compare
New push, after @umut-sahin 's comments |
8d9cda1
to
8a6e6df
Compare
New push, after @umut-sahin 's comments |
5f01e8b
to
079e70b
Compare
Added few lines to make the key generation separately, but still, the execution time of the first update is often significantly slower than the next ones. |
Added the gif. Good with you, @umut-sahin @youben11 @BourgerieQuentin ? |
4839ccf
to
7991881
Compare
Squashing all commits locally |
I feel it missing some explanation of how is it implemented and why there are several implementation, maybe also some timings etc? wdyt? |
I understand but my .md is much larger than existing .md's in this directory :)
I am writing a google doc, which will be published at some point, and we can add the link here. Is it ok with you? Or, do you want me to copy some parts of the doc here? |
Yes sure a blog + a future link into the doc will be great 👍 |
So, can I merge? I need approvals please |
Or, if you want, I add a line in the .md to say "technical explanations are coming"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the python file to frontends/concrete-python/examples
, and add game_of_life.md
to SUMMARY.md
🙂
7991881
to
336701a
Compare
336701a
to
11f106f
Compare
cf8e571
to
6951cce
Compare
My last comment is, maybe we can turn this into a notebook as well 🤔 |
Pushed fixes for @rudy-6-4 comments, except the import order: I don't know what you want, exactly |
but, it's a game, why would we want a notebook |
Right, forgot for a second 😁 |
All good for me then once the CI is green! |
frontends/concrete-python/examples/game_of_life/game_of_life.py
Outdated
Show resolved
Hide resolved
7afe94d
to
b0fb6e7
Compare
Tests are green. And normally, I have taken all your comments into account. |
24a5300
to
2c81312
Compare
2c81312
to
abfaaa6
Compare
There was another correctness issue: FAILED private/var/folders/vv/vxg0wps1631b2129g22s6hs00000gn/T/tmp.6POUyu3s/tests/execution/test_mul.py::test_constant_mul[parameters1-x * 3] |
closes #457