Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

woppbs simulation #580

Merged
merged 6 commits into from
Sep 28, 2023
Merged

woppbs simulation #580

merged 6 commits into from
Sep 28, 2023

Conversation

youben11
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 25, 2023
@youben11 youben11 force-pushed the simulation-wop-pbs branch 2 times, most recently from 5a59261 to c4b1ee6 Compare September 25, 2023 09:56
Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanups are missing, I'll restart the review after.

nounwind(|| {
assert!(64 <= number_of_bits_to_extract + delta_log);

// let lwe_list_out =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are other part in the code with comment to cleanup

@youben11 youben11 force-pushed the simulation-wop-pbs branch 2 times, most recently from 73be3af to 04c97c4 Compare September 26, 2023 17:52
@youben11 youben11 merged commit e4835bd into main Sep 28, 2023
24 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants