Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix noise in woppbs #592

Merged
merged 2 commits into from
Nov 22, 2023
Merged

fix noise in woppbs #592

merged 2 commits into from
Nov 22, 2023

Conversation

samcrx
Copy link
Collaborator

@samcrx samcrx commented Oct 6, 2023

Simulation was underestimating the noise after a woppbs.
This should fix the issue.

Still need to do some change on the compiler side (signature of the vertical_packing function has changed)

@cla-bot cla-bot bot added the cla-signed label Oct 6, 2023
@samcrx samcrx requested a review from youben11 October 6, 2023 16:37
@youben11 youben11 marked this pull request as ready for review October 24, 2023 08:42
@aPere3 aPere3 self-requested a review October 24, 2023 15:01
@rudy-6-4 rudy-6-4 force-pushed the simu-woppbs-fix branch 3 times, most recently from 5d3bee7 to 58d122d Compare November 6, 2023 16:37
@rudy-6-4
Copy link
Contributor

rudy-6-4 commented Nov 7, 2023

zig test need to be updated

@rudy-6-4 rudy-6-4 merged commit a4db568 into main Nov 22, 2023
28 of 32 checks passed
@rudy-6-4 rudy-6-4 deleted the simu-woppbs-fix branch January 24, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants