Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Key Value Database Example #599

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix: Key Value Database Example #599

merged 2 commits into from
Oct 25, 2023

Conversation

umut-sahin
Copy link
Contributor

(closes #598)

@umut-sahin umut-sahin self-assigned this Oct 18, 2023
@cla-bot cla-bot bot added the cla-signed label Oct 18, 2023
@@ -32,7 +41,15 @@ def hint(x: Union[Tracer, Any], *, bit_width: Optional[int] = None) -> Union[Tra
if not isinstance(x, Tracer): # pragma: no cover
return x

bit_width_hint = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we reject invalid value ?
E.g. bit_width = 0 is ignored.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the semantically correct behavior. bit_width = 0 in this context means bit width needs to be at least 0 which will always be the case so we can ignore the constraint as it's already satisfied.

@umut-sahin umut-sahin merged commit 88f06aa into main Oct 25, 2023
22 of 23 checks passed
@umut-sahin umut-sahin deleted the fix/kbdb branch October 25, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot query encrypted KeyValueDatabase examples
2 participants