Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Force linking of libomp with libstdc++ in debug builds #615

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

andidr
Copy link
Contributor

@andidr andidr commented Nov 16, 2023

Debug builds preserve assertions in libomp, which are implemented using code form libstdc++. However, the build rules for libomp explicitly prevent the library from being linked with libstdc++ by default, resulting in a linker error for debug builds.

This patch sets the option LIBOMP_USE_STDCPPLIB for libomp to ON for debug builds in order to force linking with libstdc++.

Debug builds preserve assertions in libomp, which are implemented
using code form libstdc++. However, the build rules for libomp
explicitly prevent the library from being linked with libstdc++ by
default, resulting in a linker error for debug builds.

This patch sets the option `LIBOMP_USE_STDCPPLIB` for libomp to `ON`
for debug builds in order to force linking with libstdc++.
@andidr andidr requested review from soonum and umut-sahin November 16, 2023 10:15
@cla-bot cla-bot bot added the cla-signed label Nov 16, 2023
Copy link
Contributor

@umut-sahin umut-sahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andidr andidr merged commit ed8d1f3 into main Nov 16, 2023
21 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants